code review

getPuKxCx

src/main/java/com/josh/vku2f/CTAP2.java

@@ -415,8 +415,12 @@ public class CTAP2 extends Applet implements ExtendedLength {
 		cborDecoder.init(dataBuffer, (short) 1, dataLength);
 		try {
 			cborDecoder.readMajorType(CBORBase.TYPE_ARRAY);
+
+			// read IDx
 			short length = cborDecoder.readTextString(scratch, (short) 0);
 			idSecret.IDx = new DomString(scratch, length);
+
+			// read PuKp
 			cborDecoder.readByteString(scratch, (short) 0);
 			Util.arrayCopy(scratch, (short) 8, idSecret.PuKp, (short) 1, (short) 64);
 		} catch (UserException e) {
@@ -429,14 +433,19 @@ public class CTAP2 extends Applet implements ExtendedLength {
 		idSecret.initAesKey();
 		idSecret.encryptCx();
 
+		// make output cbor
 		cborEncoder.init(dataBuffer, (short) 0, (short) 1200);
 		cborEncoder.startArray((short) 2);
+
+		// put PuKx
 		short length = attestationKeyPair.getPubkey(scratch, (short) 0);
 		cborEncoder.encodeByteString(scratch, (short) 0, length);
+
+		// put encryptedCx
 		cborEncoder.encodeByteString(idSecret.encryptedCx, (short) 0, (short) idSecret.encryptedCx.length);
 
 		//for test
-		idSecret.getHMAC(scratch, (short) 0);
+//		idSecret.getHMAC(scratch, (short) 0);
 
 		apdu.setOutgoing();
 		apdu.setOutgoingLength(cborEncoder.getCurrentOffset());